Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore DCM error for type assertion #6185

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

elliette
Copy link
Member

Follow up to #6184

Address #6184 (comment)

@elliette elliette requested a review from a team as a code owner August 11, 2023 16:43
@elliette elliette requested review from bkonyi and CoderDake and removed request for a team and bkonyi August 11, 2023 16:43
@elliette
Copy link
Member Author

@incendial - any idea why this rule is giving a false positive here? and why ignoring it doesn't seem to work? Thanks!

@incendial
Copy link
Contributor

@elliette thanks for the mention, looks like a false-positive, will check.

@incendial
Copy link
Contributor

@elliette which dcm version you have (dcm --version)? I can't reproduce it with the latest one.

@incendial
Copy link
Contributor

Hm, I see it only under one condition: if I comment out the 'package:extension_discovery/extension_discovery.dart' (so, basically, if the Extension is not resolved). Do you run flutter pub get before dcm checks? Also I've noticed that for me sh tool/pull_and_refresh.sh did not install extension_discovery, only running flutter pub get manually helped.

@elliette
Copy link
Member Author

Hm, I see it only under one condition: if I comment out the 'package:extension_discovery/extension_discovery.dart' (so, basically, if the Extension is not resolved). Do you run flutter pub get before dcm checks? Also I've noticed that for me sh tool/pull_and_refresh.sh did not install extension_discovery, only running flutter pub get manually helped.

Thanks! Looks like we weren't - I've opened #6204 and will try re-running the workflow after that has been submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants