Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text selection issues in the codeview and console #6099

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix text selection issues in the codeview and console #6099

merged 2 commits into from
Jul 25, 2023

Conversation

elliette
Copy link
Member

Fixes issues reported in #6079

With this change:

  1. highlighting in the console removes any selection areas in the codeview and visa versa
  2. highlighting in the console and then right clicking maintains the current text selection
  3. cmd+c works in the console (and in codeview, but that was working for me before this change)

The reason this wasn't working before was because we had a SelectionArea (for the expandable variable TreeView) nested inside another SelectionArea (for the console). Now we only have the SelectionArea for the console.

See demo:

selection fixes

@elliette elliette requested a review from a team as a code owner July 25, 2023 22:53
@elliette elliette requested review from kenzieschmoll and removed request for a team July 25, 2023 22:53
@elliette elliette merged commit dba0abf into flutter:master Jul 25, 2023
@polina-c polina-c mentioned this pull request Aug 29, 2023
Closed
@elliette elliette mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @kenzieschmoll