Add connection info widgets and clean up device dialog #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Jul 7, 2023
| } | ||
| } | ||
|
|
||
| class VMFlagsDialog extends StatefulWidget { |
There was a problem hiding this comment.
all of this code below was copied to vm_flag_widgets.dart
kenzieschmoll
commented
Jul 7, 2023
| } | ||
| } | ||
|
|
||
| class VMFlagsDialog extends StatefulWidget { |
There was a problem hiding this comment.
all of the code below was copied. No functional changes.
polina-c
approved these changes
Jul 7, 2023
kenzieschmoll
commented
Jul 7, 2023
Comment on lines
+66
to
+88
| return Column( | ||
| mainAxisSize: MainAxisSize.min, | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
| for (var entry in entries) | ||
| Padding( | ||
| padding: EdgeInsets.only( | ||
| bottom: entry == entries.last ? 0.0 : denseRowSpacing, | ||
| ), | ||
| child: Row( | ||
| mainAxisSize: MainAxisSize.min, | ||
| children: [ | ||
| Text('${entry.title}: ', style: boldText), | ||
| SelectableText( | ||
| entry.description, | ||
| style: theme.subtleTextStyle, | ||
| ), | ||
| if (entry.actions.isNotEmpty) ...entry.actions, | ||
| ], | ||
| ), | ||
| ), | ||
| ], | ||
| ); |
There was a problem hiding this comment.
copied from device_dialog.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors some code out of device_dialog.dart and into
connection_info.dartandvm_flag_widgets.dart. This is breaking up a larger change to support static tooling in DevTools, and these shared widgets will be used on the landing / home screen in a follow up PR.