Stop logging http to timeline by default and warn users about memory implications #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4353. (please review with Hide Whitespace enabled)
This stops enabling http timeline logging by default on the performance page (this can still be enabled from the timeline stream settings dialog on the Timeline Events view). This setting will continue to be enabled by default when a user switches to the network page.
Additionally, this PR adds a warning on the memory screen when this setting is enabled. Users have made several reports being confused by the memory dart:io is holding onto for debugging. This warning allows the user to disable the http logging and automatically dismisses.