Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame numbers to the flutter frames chart in the performance page #3526

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

kenzieschmoll
Copy link
Member

Work towards #3485, specifically addressing the feedback here - @ayanogawa

Screen Shot 2021-12-08 at 4 43 47 PM

When the frame analysis feature is turned on, these numbers will match the frame tab titles:
Screen Shot 2021-12-08 at 4 39 49 PM

@kenzieschmoll kenzieschmoll merged commit b4e4043 into flutter:master Dec 9, 2021
@kenzieschmoll kenzieschmoll deleted the numbered-frames branch December 9, 2021 16:26
@ayanogawa
Copy link

Awesome work!
For the magnifying glasses, can we style it like the attachment?
Circle - .8 opacity of #303030, 20 X 20 px
Magnifying glass - #ffffff, 12 X 12 px

Thank you in advance.

timeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants