Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dev.nix #2267

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Simplify dev.nix #2267

merged 1 commit into from
Dec 6, 2024

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Dec 6, 2024 •
edited
Loading

I was being over ambitious with attempting to automatically flutter pub get all the things. Turns out, can't subshell in dev.nix

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

rodydavis
rodydavis approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@rodydavis rodydavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domesticmouse domesticmouse merged commit 86fc85e into main Dec 6, 2024
10 checks passed
@domesticmouse domesticmouse deleted the Simplify-dev.nix branch December 6, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodydavis rodydavis rodydavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domesticmouse @rodydavis