Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homescreen codelab] Update dependencies #2210

Merged

Conversation

wrbl606
Copy link
Contributor

@wrbl606 wrbl606 commented Jun 15, 2024

  • Update home_widget to 0.6.0, which adds support for Flutter 3.20+
  • Bump Kotlin version of the Android project as the fix suggests (see the message below)
┌─ Flutter Fix ──────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Your project requires a newer version of the Kotlin Gradle plugin.                             │
│ Find the latest version on https://kotlinlang.org/docs/releases.html#release-details, then update  │
│ /Users/marcinwroblewski/Documents/Projects/flutter-codelabs/homescreen_codelab/step_03/android/bui │
│ ld.gradle:                                                                                         │
│ ext.kotlin_version = '<latest-version>'                                                            │
└────────────────────────────────────────────────────────────────────────────────────────────────────┘

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@wrbl606
Copy link
Contributor Author

wrbl606 commented Jun 16, 2024

Tests for Windows have failed, marking the checks as failed, but I don't think my changes caused that. It looks like the Flutter installation step has issues, can we circumvent the check and merge this to main or do I have to debug the Windows workflow?

@parlough parlough requested a review from ericwindmill June 16, 2024 06:26
@parlough
Copy link
Member

parlough commented Jun 16, 2024

Tests for Windows have failed, marking the checks as failed, but I don't think my changes caused that. It looks like the Flutter installation step has issues, can we circumvent the check and merge this to main or do I have to debug the Windows workflow?

No need worry about the unrelated Windows failure, but thanks for thinking about it :) - I've opened a fix in flutter/flutter#150314.

Thanks again for the PR. I'll leave landing the change to @ericwindmill though so he is aware of the update.

@domesticmouse domesticmouse added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2024
Copy link

auto-submit bot commented Jun 16, 2024

auto label is removed for flutter/codelabs/2210, due to - The status or check suite Test Flutter beta on windows-latest has failed. Please fix the issues identified (or deflake) before re-applying this label.

@domesticmouse domesticmouse merged commit 42192df into flutter:main Jun 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants