Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfiles moved to root for shared libraries #4071

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Dockerfiles moved to root for shared libraries #4071

merged 1 commit into from
Dec 4, 2024

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Dec 4, 2024 •
edited
Loading

Fixes locally what was previously failing

> docker build -t test -f Dockerfile.app_dart

Downloading packages...
...
+ cocoon_server 0.0.0 from path ../cocoon_server

@jtmcdole
Dockerfiles need to be at the root if we're going to reference parent…
fb29d21 
… folders

```
> docker build -t test -f Dockerfile.app_dart

Downloading packages...
...
+ cocoon_server 0.0.0 from path ../cocoon_server
```
@jtmcdole jtmcdole changed the title Dockerfiles need to be at the root if we're going to reference parent… Dockerfiles moved to root for shared libraries Dec 4, 2024
@jtmcdole
Copy link
Contributor Author

jtmcdole commented Dec 4, 2024

Cocoon app and auto_submit are currently not deployable:

https://pantheon.corp.google.com/cloud-build/builds;region=global/6abd3141-5827-4f46-a9ff-3e912e7fcb65;step=1?inv=1&invt=AbjPcg&project=flutter-dashboard

https://pantheon.corp.google.com/cloud-build/builds;region=global/09e71c1d-0837-4a67-8392-55c02b3de873;step=0?inv=1&invt=AbjPcg&project=flutter-dashboard

yjbanov
yjbanov approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtmcdole jtmcdole merged commit 09fad27 into flutter:main Dec 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtmcdole @yjbanov