Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file location to file name in log message #61

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Change file location to file name in log message #61

merged 1 commit into from
Mar 31, 2021

Conversation

rwalczyna
Copy link

File location has been changed to file name.

Currently logs are a bit messy:

D/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/tizen_renderer_ecore_wl2.cc: SetupDisplay(28) > ecore_wl2_display_: 0xb8f0e2d8
W/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
W/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
D/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/tizen_embedder_engine.cc: RunEngine(174) > FlutterEngineRun Success!
E/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/flutter_tizen.cc: FlutterDesktopRegistrarGetTextureRegistrar(221) > Tizen DesktopTexture support is not implemented yet.
D/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/channels/localization_channel.cc: SendLocales(41) > Choose Default locale[en_US]
D/ConsoleMessage( 9291): ../../../../flutter/shell/platform/tizen/channels/localization_channel.cc: SendLocales(56) > Send 782 available locales

After change:

D/ConsoleMessage( 9064): tizen_renderer_ecore_wl2.cc: SetupDisplay(28) > ecore_wl2_display_: 0xb82105d8
W/ConsoleMessage( 9064): tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
W/ConsoleMessage( 9064): tizen_renderer.cc: OnProcResolver(204) > Could not resolve: glGetStringi
D/ConsoleMessage( 9064): tizen_embedder_engine.cc: RunEngine(174) > FlutterEngineRun Success!
E/ConsoleMessage( 9064): flutter_tizen.cc: FlutterDesktopRegistrarGetTextureRegistrar(221) > Tizen DesktopTexture support is not implemented yet.
D/ConsoleMessage( 9064): localization_channel.cc: SendLocales(41) > Choose Default locale[en_US]
D/ConsoleMessage( 9064): localization_channel.cc: SendLocales(56) > Send 782 available locales

Signed-off-by: Rafal Walczyna [email protected]

swift-kim
swift-kim approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbrto21 bbrto21 merged commit 57547bb into flutter-tizen:flutter-2.0.1-tizen Mar 31, 2021
@swift-kim
Copy link
Member

@bbrto21 Hmm? That's not even possible.

@bbrto21
Copy link

bbrto21 commented Apr 1, 2021

@swift-kim What a mistake! I misunderstood that they were the same person 😆

swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@chinmaygarde @dnfield
Add LICENSE file. (#61)
24d7083 
Matches the one in the engine exactly as described in the [umbrella issue](flutter/flutter#97686).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swift-kim swift-kim swift-kim approved these changes

@pkosko pkosko pkosko approved these changes

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalczyna @swift-kim @bbrto21 @pkosko