-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add locationComponent#getLastLocation #922
add locationComponent#getLastLocation #922
Conversation
looks good but can you run |
@felix-ht I'll try that |
@felix-ht I did the format |
Any progress on this issue? |
@felix-ht I did the |
the issue the lint complains about is:
can you run it again? |
I did multiple time
|
what's your swift format version? we run 0.48.18 checked with your branch and i get:
you can also just apply this git diff and commit it (or cherry pick this commit - 01c4326) diff --git a/ios/Classes/OfflinePackDownloadManager.swift b/ios/Classes/OfflinePackDownloadManager.swift
index b9fa0d9..783ba58 100644
--- a/ios/Classes/OfflinePackDownloadManager.swift
+++ b/ios/Classes/OfflinePackDownloadManager.swift
@@ -56,8 +56,7 @@ class OfflinePackDownloader {
let tilePyramidRegion = regionDefinition.toMGLTilePyramidOfflineRegion()
storage
.addPack(for: tilePyramidRegion,
- withContext: regionData.prepareContext())
- { [weak self] pack, error in
+ withContext: regionData.prepareContext()) { [weak self] pack, error in
if let pack = pack {
self?.onPackCreated(pack: pack)
} else { |
@samderlust btw the issue with the formatting was that your branch was month behind master |
mapbox 0.15.0 missing
requestMyLocationLatLng
on iosmy first PR and first time work with Swift. let me know if something need to change
related #405