Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of toggling layer visibility #1197

Merged
merged 6 commits into from
May 5, 2023
Merged

Implementation of toggling layer visibility #1197

merged 6 commits into from
May 5, 2023

Conversation

srmncnk
Copy link
Contributor

@srmncnk srmncnk commented Oct 10, 2022

This PR addresses toggling layer visibility when a correct layer ID is supplied.

Works cross-platform. Implementation in example project provided as well.

felix-ht
felix-ht requested changes Oct 10, 2022
View reviewed changes
lib/src/controller.dart Show resolved Hide resolved
mapbox_gl_web/lib/src/mapbox_web_gl_platform.dart Outdated Show resolved Hide resolved
@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 11, 2022

Thanks. Added requested changed in 7438711.

Would this throw if the layer does not exist?
If so this would be the only platform were this would be the case right?

It does not throw, however it leaves a 'null' message in the debug window, which is rather annoying, so I added the check anyway.

@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 11, 2022 10:57 Failure
@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 11, 2022 10:57 Failure
@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 12, 2022

Fixed linter errors as well.

@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 17, 2022 14:33 Failure
@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 17, 2022 14:33 Failure
@felix-ht felix-ht had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 17, 2022 14:36 Failure
@felix-ht felix-ht had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 17, 2022 14:36 Failure
@ivan-ljubicic ivan-ljubicic mentioned this pull request Oct 21, 2022
Closed
@carson1998
Copy link

carson1998 commented Oct 21, 2022 •
edited
Loading

im in need of this function. Hopefully we can get this update soon

@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 21, 2022

I think this is ready to be merged.

@carson1998
Copy link

I'm seeing some failed checks for this change request. What seems to be the problem?

@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 26, 2022

No failed checks. This repo's CI fails to build artifacts because of incorrectly wired secrets / tokens. This is ready to be merged. @felix-ht

@felix-ht
Copy link
Collaborator

@srmanc the checks actually failed as of #1212

@felix-ht
Copy link
Collaborator

@srmanc could you rebase on master?

hungtrn75 and others added 2 commits October 26, 2022 14:13
@hungtrn75
Support heatmap layer & fill extrusion layer & update image source (f…
67a356b 
…lutter-mapbox-gl#1187)

* fix: can not find path when run script in macOS & nested dart types errors

* fix: can not sync project

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* feat: support heatmap layer

* local pbxproj

* fix: error when not await future setSymboAllowOverlap in example

* fix: error when not await future setSymboAllowOverlap in example

* add fill extrusion example

* fix: error generate code swift template with snake case

* migration: edit swift template & add ios rename props

* feat: support fill extrusion layer

* ci: run jobs

* docs: support fill extrusion layer

* docs: support fill extrusion layer

* refactor codegen

* add update image source example

* feat: update image for image source

* remove xcode teamid
@srmncnk
Backwards compatibility for delayed disposal in flutter 2.x (flutter-…
01eb70e 
…mapbox-gl#1217)

* Backwards compatibility for delayed disposal in flutter 2.x

* Backwards compatible TextureAndroidViewController with support for size in create method

* Formatting cleanup

Co-authored-by: Simon Irmančnik <[email protected]>
@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 26, 2022

@felix-ht You're right, didn't see that. Just rebased.

@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 12:40 Failure
@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 12:40 Failure
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 12:41 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 12:41 Inactive
@felix-ht
Copy link
Collaborator

@srmanc i think something went wrong with the merge - (cherry pick?) - as this shows a large number of changes (same with the other pr)

@srmncnk
Copy link
Contributor Author

srmncnk commented Oct 26, 2022

@felix-ht I just did rebase on master and then a pull --rebase and a push, somehow changes did not reflect the master tip. I did another merge with master and pushed, seems okay now.

@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 13:55 Failure
@srmncnk srmncnk had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN October 26, 2022 13:55 Failure
@carson1998
Copy link

still pending huh.

@srmncnk
Copy link
Contributor Author

srmncnk commented Nov 29, 2022

@felix-ht Do you think we could look at all the pending PRs in the near future? @carson1998

@connybruhn
Copy link

I'm also waiting for this important feature. I need it for a radar player in my weather app.
Is there a chance to get that feature this year? Otherwise I would have to switch back to another map package.

@connybruhn
Copy link

Any news here? I would really like to use this package, but I need that feature.

@srmncnk
Copy link
Contributor Author

srmncnk commented Mar 6, 2023

Ping.

@stale
Copy link

stale bot commented May 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 5, 2023
felix-ht
felix-ht approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale stale bot removed the stale label May 5, 2023
@felix-ht felix-ht merged commit 318078a into flutter-mapbox-gl:master May 5, 2023
sandrews-inc pushed a commit to Get-Phil/flutter-mapbox-gl that referenced this pull request May 15, 2023
@srmncnk @sandrews-inc
Implementation of toggling layer visibility (flutter-mapbox-gl#1197)
abea458 
* Implementation of toggling layer visibility

* Added documentation to setVisibility, added check if layerId exists

* Fixed linter errors

Co-authored-by: Simon Irmančnik <[email protected]>
@dhaq
Copy link

dhaq commented Jun 8, 2023

When can I use this toggle layer visibility feature?

FreeGrow added a commit to FreeGrow/maps that referenced this pull request Sep 21, 2023
@FreeGrow
Revert "Implementation of toggling layer visibility (flutter-mapbox-g…
d1b7755 
…l#1197)"

This reverts commit 318078a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ht felix-ht felix-ht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@srmncnk @carson1998 @felix-ht @connybruhn @dhaq @hungtrn75