Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1455 improve input decoration enabled property #1464

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

deandreamatias
Copy link
Collaborator

Connection with issue(s)

Close #1455

Connected to flutter/flutter#161602

Solution description

  • Add an assert to warning the developer to avoid decoration.enabled use

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias deandreamatias marked this pull request as ready for review January 14, 2025 16:59
@deandreamatias deandreamatias changed the title feat: improve input decoration enabled property feat: #1455 improve input decoration enabled property Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (ec7543b) to head (284faa1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/form_builder_field_decoration.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
+ Coverage   90.08%   90.25%   +0.16%     
==========================================
  Files          21       21              
  Lines         827      831       +4     
==========================================
+ Hits          745      750       +5     
+ Misses         82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias merged commit 7754009 into main Jan 14, 2025
5 of 7 checks passed
@deandreamatias deandreamatias deleted the bugfix/#1455-enabled-decoration branch January 14, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General]: When decoration is disabled, form field is enabled
1 participant