Codearena 154, Incorrect Decoding of Swap Results Leads to Ineffectiv…

…e Slippage Protection
fluidity-money · Sep 23, 2024 · 1e49a07 · 1e49a07
1 parent 65c99fc
commit 1e49a07
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/sol/SeawaterAMM.sol b/pkg/sol/SeawaterAMM.sol
@@ -313,7 +313,7 @@ contract SeawaterAMM is ISeawaterAMM {
         ));
         require(success, string(data));
 
-        (int256 swapAmountIn, int256 swapAmountOut) = abi.decode(data, (int256, int256));
+        (int256 swapAmountOut, int256 swapAmountIn) = abi.decode(data, (int256, int256));
         require(swapAmountOut >= int256(minOut), "min out not reached!");
         return (swapAmountIn, swapAmountOut);
     }
@@ -335,7 +335,7 @@ contract SeawaterAMM is ISeawaterAMM {
         ));
         require(success, string(data));
 
-        (int256 swapAmountIn, int256 swapAmountOut) = abi.decode(data, (int256, int256));
+        (int256 swapAmountOut, int256 swapAmountIn) = abi.decode(data, (int256, int256));
         require(swapAmountOut >= int256(minOut), "min out not reached!");
         return (swapAmountIn, swapAmountOut);
     }
@@ -410,7 +410,7 @@ contract SeawaterAMM is ISeawaterAMM {
     }
 
     /// @inheritdoc ISeawaterExecutorAdminExposed
-    function tickSpacing653FE28F(address /* pool */) external returns (uint8) {
+    function tickSpacing653FE28F(address /* pool */) external returns (uint16) {
         directDelegate(_getExecutorAdmin());
     }