fix: sort temperature sensors by type and name #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
matmen
approved these changes
Nov 21, 2022
|
Hi Pedro. It fixes it mostly. The list is sorted alphabetically groupwise in the main thermals window, but the pop-up window is not. The pop-up should most likely have the same order as the main window with the greyed out entries not shown.
|
|
Also in the main window the name is parsed for special characters replaced by spaces and space added in front of capital letters within the name (not the first letter I assume). You may want to parse the name in the pop-up the same way and keep the same group wise order (with the greyed-out entries removed). |
koriwi
pushed a commit
to koriwi/fluidd
that referenced
this pull request
Dec 15, 2022
Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the thermals are grouped by heaters on top, then temperature fan, and finally temperature sensors, but these are unordered inside these groups.
This PR ensures that we still keep the above grouping, and then inside each group we sort by sensor type, and finally name.
Fixes #956
Signed-off-by: Pedro Lamas [email protected]