Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable dashboard controls if Klipper is not ready #811

Merged

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Aug 4, 2022

Current behavior:

  • macro buttons only disable when printing (if set as such)
  • console controls are always enabled
  • labels are always "foreground" text

This changes that to ensure that these controls are disabled if Klipper is down.

Signed-off-by: Pedro Lamas [email protected]

@pedrolamas pedrolamas added the GH - Bug Something isn't working label Aug 4, 2022
@pedrolamas pedrolamas added this to the 1.20 milestone Aug 4, 2022
@pedrolamas pedrolamas requested review from kerbilg and matmen August 4, 2022 10:44
@pedrolamas pedrolamas changed the title fix: disable macro buttons if Klipper is not ready fix: disable dashboard controls if Klipper is not ready Aug 4, 2022
kerbilg
kerbilg previously approved these changes Aug 4, 2022
@pedrolamas pedrolamas merged commit 7028b15 into fluidd-core:develop Aug 4, 2022
@pedrolamas pedrolamas deleted the pedrolamas/macro-btn-disable branch August 4, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants