feat(ui): make color picker movable #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmen
added
FR - Enhancement
|
Just checking, but have you tested this on the phone too? |
|
I just tested in Windows + MSEdge and this is not working correctly (mouse pointer is not over title bar and text gets selected)
|
|
Oops, looks like I have some more browser testing to do. Thanks for the QA. |
Signed-off-by: Mathis Mensing <[email protected]>
matmen
force-pushed
the
feat/movable-color-picker
branch
from
2ed0563
to
15de214
Compare
pedrolamas
reviewed
Mar 15, 2022
|
Just tested with the new changes, seems to be working fine on desktop (haven't tried phone yet!) |
Signed-off-by: Mathis Mensing <[email protected]>
|
I tested this on my phone and also via Chrome's mobile emulation, worked fine over there ;) |
pedrolamas
previously approved these changes
Mar 16, 2022
pedrolamas
reviewed
Mar 16, 2022
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
approved these changes
Mar 16, 2022
matmen
added a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Mathis Mensing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a draggable title to the color picker card - now they can be moved anywhere you'd like ;)
Closes #332