-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds keyboard shortcuts #1404
feat: adds keyboard shortcuts #1404
Conversation
5223968
to
55007bb
Compare
Signed-off-by: Pedro Lamas <[email protected]>
55007bb
to
d3d1378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small question:
Replaced Ctrl+Shift+F12 with Ctrl+Alt+F12 for Emergency Stop Adds Ctrl+Shift+P for Pause and Ctrl+Shift+C for Cancel Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Both the pause and cancel shortcuts conflict with some firefox shortcuts (new private window and element picker respectively), and while Ctrl+Shift+C seems to work fine when printing (only opens the element picker when the printer is idle), Ctrl+Shift+P always opens a new private window for me |
I have a feeling I am opening a can of worms here... I'm going to check the keyboard shortcuts that Gmail uses and try to use those (should be safer, I guess...) |
Replaced Ctrl+Shift+P with Shift+P for Pause Print Replaced Ctrl+Shift+C with Shift+C for Cancel Print Signed-off-by: Pedro Lamas <[email protected]>
I've set I now got myself thinking... arrows to control the toolhead? 😁 Like Shift+arrow key and that would move the toolhead in the indicated direction by 10mm? |
Signed-off-by: Pedro Lamas <[email protected]>
With just Shift+P and Shift+P I now can't type any upper case commands containing a C or P in the console while a print is running ;) I assume the event handler is just missing the
I guess that could work - maybe it could even use the configured move distances using the number keys, but that'd be a lot of combinations to remember haha |
Signed-off-by: Pedro Lamas <[email protected]>
Oops... fixed now! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds support for keyboard shortcuts!
Keyboard Shortcuts dialog (shown with ?)
Button tooltips (shown only if Keyboard Shortcuts are enabled)
Settings entry