feat(spoolman): QR code scanning support #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
reviewed
Aug 14, 2023
Co-authored-by: Pedro Lamas <[email protected]>
pedrolamas
previously approved these changes
Aug 14, 2023
Signed-off-by: Mathis Mensing <[email protected]>
|
@NonaSuomy Feel free to test these changes, I just added support for using the device's camera as a scan source |
|
@matmen To fix #1150, I made Having said that we now know that this will still fail if the streaming server is not setting the |
|
And while we're at it, we might want to add #1151 here? |
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
Signed-off-by: Mathis Mensing <[email protected]>
pedrolamas
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1119
Adds support for spoolman QR codes (Donkie/Spoolman#10).
Adds an option to automatically commit a spool selection when a valid QR code is scanned (no need to manually confirm the selection)
Adds support for using the device's camera as a scan source (#1119 (comment))
Closes #1151