fix: hide Pressure Advance if no default extruder stepper set #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
matmen
approved these changes
May 26, 2022
matmen
pushed a commit
to matmen/fluidd
that referenced
this pull request
Jun 27, 2022
…-core#694) Signed-off-by: Pedro Lamas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Klipper doesn't seem to provide what
extruder_stepperis currently active so Moonraker can't make it available to the API consumers.The only way forward in this for now is to just "hide" the full Pressure Advance controls if no
pressure_advancevalues are provided in the active extruder (meaning no stepper is set)Fixes #681
Signed-off-by: Pedro Lamas [email protected]