Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New slider (PA, smooth time) does not work proper with extruder_stepper config #681

Closed
homasholz opened this issue May 18, 2022 · 16 comments · Fixed by #694 or #1022
Closed

New slider (PA, smooth time) does not work proper with extruder_stepper config #681

homasholz opened this issue May 18, 2022 · 16 comments · Fixed by #694 or #1022
Assignees
Labels
GH - Bug Something isn't working
Milestone

Comments

@homasholz
Copy link

Browser

Chrome

Device

Desktop PC

Operating System

Windows

What happened

when using the new sliders, the command behind it does not work with my extruder config

image
image
image
image
image

What did you expect to happen

that the sider/command works proper

How to reproduce

using extruder_stepper in config

Additional information

No response

@homasholz homasholz added GH - Bug Something isn't working GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability labels May 18, 2022
@pedrolamas pedrolamas removed the GH - Evaluation Needed This topic needs to be discussed to evaluate it's aspects and feasability label May 18, 2022
@pedrolamas
Copy link
Member

@homasholz Thank you for taking the time to submit this bug report!

I've confirmed this issue, seems we need to add support for extruder_stepper configurations which we currently don't have.

@matmen matmen added this to the 1.18.2 milestone May 20, 2022
@pedrolamas
Copy link
Member

I've been discussing this issue with Mainsail developer/contributor @th33xitus and we have come to the conclusion that currently, there is no way to know what extruder_stepper is active...

Klipper doesn't seem to provide that information and so Moonraker can't make it available to the API consumers.

As this will require Klipper changes, I am marking this as an "upstream" issue, and considering just hiding these controls when extruder_stepper are in the config file (or some other check).

@pedrolamas
Copy link
Member

Granted that I might be wrong here, but from my tests it seems that SET_PRESSURE_ADVANCE now works with multiple extruder_stepper entries (though it just sets the active extruder, not the extruder_stepper!

At least Fluidd 1.20.1 is now showing the Pressure Advance controls (though we didn't actually change anything!) and these seem to work... are you able to confirm this, @homasholz ?

@homasholz
Copy link
Author

homasholz commented Nov 4, 2022

I dont have the sliders available.

image
image

@pedrolamas
Copy link
Member

pedrolamas commented Nov 4, 2022

Are you using the latest (dev) version of Klipper?

Can you take a screenshot of the Updates information in Fluidd Settings page?

@homasholz
Copy link
Author

i am on v0.10.0-615-g96ea871b

image

@pedrolamas
Copy link
Member

Ah, there you go then! A have a feeling you will need to press that little "update" button next to Klipper to get that on working condition.

Be aware that if you update Moonraker you will also need to update the folder structure (it should do it automatically, but I've seen reports of people having to do extra manual steps)

@homasholz
Copy link
Author

Ok. I have updated everything.
But no PA sliders appear (i think they should be in tools section).

@pedrolamas
Copy link
Member

Maybe I was wrong then... Nevertheless, you might want to try and manually send a SET_PRESSURE_ADVANCE ADVANCE=0.5 and see what happens!

@homasholz
Copy link
Author

Screenshot_2022-11-05-00-50-12-39_40deb401b9ffe8e1df2f1cc5ba480b12

@pedrolamas
Copy link
Member

If you are able to upload a klippy.log from this printer so I can take a look I would be very appreciated!

@homasholz
Copy link
Author

klippy.log.txt

@pedrolamas pedrolamas reopened this Feb 1, 2023
@pedrolamas pedrolamas removed GH - Upstream First Temporarily impossible because of other factors Upstream - Klippy For everything Klipper related labels Feb 1, 2023
@pedrolamas pedrolamas removed this from the 1.18.2 milestone Feb 1, 2023
@pedrolamas pedrolamas self-assigned this Feb 1, 2023
@pedrolamas
Copy link
Member

Finally got around to check this again and now have a solution that involves showing a Pressure Advance control for each of the [extruder_stepper] entries!

image

Incoming PR for this!

@pedrolamas
Copy link
Member

@homasholz FYI, we've finally fixed this issue on Fluidd 1.23.2!

You will now see pressure advance controls per extruder_stepper (#1022)

If you also update to the latest Klipper available (which I strongly recommend), you will also get options to view/change the synced extruder (#1034) and enable/disable the stepper (#1039)

I'd be really interested in your feedback on these features! 🙂

@homasholz
Copy link
Author

GREAT!!
everything is working as expected with my setup.

image

@pedrolamas
Copy link
Member

Thanks for confirming @homasholz , took a while but we got there in the end! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
3 participants