-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support for machine peripherals #1383
feat: adds support for machine peripherals #1383
Conversation
c397f04
to
d8e7787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce! I would not add the usb id in the title since some device names can be quite long, and it's also an important piece of info I'd rather see in the table, easier to find and copy/paste. Also: Usb -> USB and Uart -> UART
I honestly am a bit on a lost with how best to show this dialog and that it would look good in both desktop and mobile... for copy-paste I will probably just add some buttons on the values, but the whole look/organization of it is what I am more on a loss. The expanders (as shown above) look a bit weird when they are all collapsed... Mainsail went for tabs, I am not fully on board with that too... |
what about using tabs instead? |
e.g. a BTT U2C v2.1 shows up as
|
2d151e3
to
8824b1d
Compare
8824b1d
to
c9f21b6
Compare
Signed-off-by: Pedro Lamas <[email protected]>
c9f21b6
to
bbc1afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality wise this LGTM, just a couple i18n related things:
Signed-off-by: Pedro Lamas <[email protected]>
Signed-off-by: Pedro Lamas <[email protected]>
Adds support for the new Moonraker Machine Peripherals (Devices)
CAN bus tab will appear if one or more CAN interfaces exist -> this bit has not been thoroughly tested as I do not have a CAN network myself that I can use for testing purposes.
Shortcut on system info card
Shortcut on file editor
On open
After refresh, no devices found
After refresh, serial devices found
After refresh, usb devices found
Resolves #1290