Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify finding MCU IDs #1290

Closed
iamthesoy opened this issue Dec 24, 2023 · 5 comments · Fixed by #1383
Closed

Simplify finding MCU IDs #1290

iamthesoy opened this issue Dec 24, 2023 · 5 comments · Fixed by #1383
Assignees
Labels
FR - Enhancement New feature or request
Milestone

Comments

@iamthesoy
Copy link

Is your feature request related to a problem? Please describe

With preconfigured OS images and pre-flashed boards becoming more and more common in printer kits, the only reason to SSH into the host is to run ls /dev/serial/by-id/* It works fine, but it would be cool if this wasn't needed, and would simplify the process for newbies.

Describe the solution you'd like

I was thinking that when editing .cfg files, an option in the right click menu that lists possible connected MCUs (which can be inserted when clicked on) would be a reasonably elegant solution - see poorly made mockup image
This could be set to only appear on lines starting with serial: to reduce clutter.
Screenshot 2023-12-24 at 10 13 11 pm

Describe alternatives you've considered

No response

Additional information

No response

@iamthesoy iamthesoy added the FR - Enhancement New feature or request label Dec 24, 2023
@pedrolamas pedrolamas added GH - Upstream First Temporarily impossible because of other factors Upstream - Moonraker For everything API related labels Jan 3, 2024
@pedrolamas
Copy link
Member

Hi @iamthesoy, thank you for submitting this feature request.

Fluidd is just a web app that runs in the browser (client side) and uses Moonraker as the server-side data provider.

In order for Fluidd to implement such feature, Moonraker will first have to provide this data to Fluidd.

@matmen
Copy link
Member

matmen commented Feb 1, 2024

FWIW this just got merged: Arksine/moonraker#798

@pedrolamas
Copy link
Member

FWIW this just got merged: Arksine/moonraker#798

Assuming these changes indeed provide the data we require, I guess we can now indeed start working on providing this feature! 🙂

@pedrolamas
Copy link
Member

Parallelly to this, I have been considering a startup wizard for when there is no printer.cfg file, where the user could just select one of the sample configs that are included with Klipper, and we would create the initial printer.cfg for the printer!

Now I guess we can also check the printer MCU address and add that to the generated printer.cfg file! 😁

@pedrolamas
Copy link
Member

I just checked... and I'm impressed!!

image

@pedrolamas pedrolamas removed Upstream - Moonraker For everything API related GH - Upstream First Temporarily impossible because of other factors labels Feb 1, 2024
@pedrolamas pedrolamas self-assigned this Feb 18, 2024
@pedrolamas pedrolamas added this to the 1.28.2 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants