Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore pending config changes in custom sections #1217

Conversation

pedrolamas
Copy link
Member

Replaces the existing "Ignore default bed mesh Pending Configuration Changes" boolean setting with a new configurable "Sections to ignore Pending Configuration Changes" combo setting.

It defaults to an empty list, but when clicked it will provide two items that can be easily added by clicking on them.

image

Besides those items, users will be able to add whatever they want to the list.

Any pending configuration changes on these sections will just be ignored and will NOT cause the "Save Config & Restart" button to show (unless some other section that is not also on this list also has pending changes).

Resolves #1210

@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Oct 26, 2023
@pedrolamas pedrolamas added this to the 1.26.2 milestone Oct 26, 2023
@pedrolamas pedrolamas requested a review from matmen October 26, 2023 12:10
@pedrolamas pedrolamas merged commit bf2bbf5 into fluidd-core:develop Oct 26, 2023
@pedrolamas pedrolamas deleted the pedrolamas/ignore-sections-config-changes branch October 26, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to fluidd config to ignore Pending changes prompt for bed_tilt_calibrate like bed_mesh is currently
2 participants