Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to fluidd config to ignore Pending changes prompt for bed_tilt_calibrate like bed_mesh is currently #1210

Closed
DaVinci-10 opened this issue Oct 21, 2023 · 2 comments · Fixed by #1217
Labels
FR - Enhancement New feature or request
Milestone

Comments

@DaVinci-10
Copy link

Is your feature request related to a problem? Please describe

Would it possible to add the bed_tilt_calibrate to a list of save_config ignore messages like
Ignore default bed mesh Pending Configuration Changes

As I have it run before each print, It would be helpful to ignore the prompt to save like bed_mesh.
image

Describe the solution you'd like

Add another slider or have the same one apply to both
image

Describe alternatives you've considered

Right now I just restart to not save.

Additional information

No response

@DaVinci-10 DaVinci-10 added the FR - Enhancement New feature or request label Oct 21, 2023
@DaVinci-10 DaVinci-10 changed the title Add to fluidd config to ignore auto_save prompt for bed_tilt_calibrate like bed_mesh is currently Add to fluidd config to ignore Pending changes prompt for bed_tilt_calibrate like bed_mesh is currently Oct 21, 2023
@pedrolamas
Copy link
Member

Hi @DaVinci-10, thanks for opening this Feature Request.

I see value in this, and we will indeed implement this.

Having said that, I am considering if we should instead add a customizable area to specify sections to ignore, instead of just adding yet another toggle switch...

It would look something like this:

image

@matmen, any thoughts on this?

@pedrolamas pedrolamas modified the milestones: 1.26.1, 1.26.2 Oct 23, 2023
@matmen
Copy link
Member

matmen commented Oct 24, 2023

@pedrolamas I think that's a good idea, not sure if it should be a multi-select with a predefined list of sections or if it should be freely configurable by the user - but I guess the latter provides more flexibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants