Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable moonraker object preprocessing #43

Merged
merged 2 commits into from
Jun 19, 2022
Merged

feat: enable moonraker object preprocessing #43

merged 2 commits into from
Jun 19, 2022

Conversation

matmen
Copy link
Member

@matmen matmen commented Jun 18, 2022

In preparation for fluidd-core/fluidd#359

@matmen matmen added the FR - Enhancement New feature or request label Jun 18, 2022
@matmen matmen requested a review from pedrolamas June 18, 2022 18:17
@matmen matmen requested a review from pedrolamas June 19, 2022 15:25
@matmen matmen merged commit 1967473 into fluidd-core:master Jun 19, 2022
@matmen matmen deleted the feat/preproc branch June 19, 2022 15:33
@pedrolamas
Copy link
Member

I've had a bit of second thoughts on this... wouldn't it make more sense to default the enable_object_processing to False and allow more advanced users to manually change it?

@matmen
Copy link
Member Author

matmen commented Jul 5, 2022

I think having it enabled by default makes sense for optimal user experience (no need for users to add a slicer post-processing script or manually toggle it on for object cancellation). What's the reason for having it disabled by default? And if it was disabled by default, we should probably add a docs page explaining the methods to enable object cancellation (and maybe even have gcode-viewer auto-loading turned off by default?).

@pedrolamas
Copy link
Member

I'm just a bit mostly worried on the performance impact of users having this enabled and installing FluiddPi on a older Raspberry Pi, hence why I had second thoughts on this!

@matmen
Copy link
Member Author

matmen commented Jul 5, 2022

Fair. I honestly have no idea what the share of older (/ low performance) devices running FluiddPi looks like, and I don't know what the performance impact is on those. I may be able to test the performance impact (at least on a Pi 3, my Pi zero doesn't have WiFi), but I think having it opt-in is just fine too.
What's your opinion on making auto loading in the gcode viewer-opt in too?

@pedrolamas
Copy link
Member

What's your opinion on making auto loading in the gcode viewer-opt in too?

Yes, that makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants