Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range component #45

Merged
merged 11 commits into from
Sep 4, 2019
Merged

Add range component #45

merged 11 commits into from
Sep 4, 2019

Conversation

ashfahan
Copy link
Member

@ashfahan ashfahan commented Sep 4, 2019

Describe the Pull request

Add range slider input component

Checklist

Before submitting
  • Update code to latest master branch
  • Test your code. Run yarn try to test run code.
What kind of change does this PR introduce? (check at least one)
  • Bugfix
  • Feature
  • Enhancement
  • Accessibility
  • Documentation update
  • Other (please describe)
If new features/enhancement are added or changed:
  • Add Modern range slider input and normalize it among various browsers
Does this PR introduce a breaking change? (check one)
  • No
  • Yes (please describe)
Did you tested this PR?
  • No
  • Yes (Browser stack)

@ashfahan ashfahan added Feature / Enhancement 💡 New feature or request component Related to components classes labels Sep 4, 2019
@ashfahan ashfahan self-assigned this Sep 4, 2019
@ashfahan ashfahan merged commit fe31d2e into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the Component-Range branch September 4, 2019 09:48
ashfahan added a commit that referenced this pull request Sep 4, 2019
Addition
➕ range component (#45)
➕ New switch input by using .switch class on checkbox type inputs
➕ Checkbox form validation
➕ add padding right for inline controls to add extra spacing in inline inputs

Fixes:
➕🔨 Sanitize: Inherit correct box sizing in IE and EDGE Range input
➕🔨 Sanitize: Remove the dropdown arrow in Chrome from inputs built with datalists
🔨 disabled opacity on %controls-label in IE
🔨 resizing %controls-label (checkbox,switch,radio) not work in IE
🔨 fix pulse animation in %controls-label (radio, checkbox, switch)
🔨 tweak switch circle size

Updates:
🆙 Use Cascading for active styles instead of !important in %controls (button, input, group-addon, range)
🆙 em units in checkbox and radio

Dropped:
🔥 remove unique disabled style from checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Related to components classes Feature / Enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant