138 revise pageservice based on latest changes for siteservice and hostservice #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 138-revise-pageservice-based-on-latest-changes-for-siteservice-and-hostservice
…hanges-for-siteservice-and-hostservice
|
close #138 |
…hanges-for-siteservice-and-hostservice
|
@ParsaGachkar I just had a small code cleanup. |
@pournasserian Done. Please check the interface and let me know if I'm missing anything. |
… data from User. so we can calculate permissions correctly. maybe we shoud move this to app context. look at this https://github.com/abpframework/abp/blob/5a2765f8cfff2d5db94460151ce7b3d123d3ef2f/framework/src/Volo.Abp.MultiTenancy/Volo/Abp/MultiTenancy/CurrentTenant.cs#L6 I think ABP handled this perfectly, it works in it's own scope and roles back to parent scope value after the current scope is finished.
…rvice-based-on-latest-changes-for-siteservice-and-hostservice
…hanges-for-siteservice-and-hostservice
pournasserian
approved these changes
Nov 16, 2023
pournasserian
deleted the
138-revise-pageservice-based-on-latest-changes-for-siteservice-and-hostservice
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #138