Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project architecture based on tech meeting #113

Merged

Conversation

MostafaTech
Copy link
Contributor

@MostafaTech MostafaTech commented Nov 2, 2023

  • Use Application Services instead of mediatR
  • Add dtos to application layer
  • Add dtos to api layer
  • Add fluent validation

Closes #112

@MostafaTech MostafaTech added the enhancement New feature or request label Nov 2, 2023
@MostafaTech MostafaTech added this to the MVP milestone Nov 2, 2023
@MostafaTech MostafaTech self-assigned this Nov 2, 2023
@MostafaTech MostafaTech marked this pull request as draft November 2, 2023 19:24
@MostafaTech
Copy link
Contributor Author

MostafaTech commented Nov 3, 2023

Adding FluentValidation to dtos and asp.net pipeline.
It uses ApiResult object like other api responses and will create results as below when validation fails:

{
  "data": null,
  "errorType": "validation",
  "errors": {
    "Name": [
      "'Name' must not be empty."
    ]
  },
  "isSuccess": false
}

@MostafaTech MostafaTech marked this pull request as ready for review November 5, 2023 11:26
@MostafaTech MostafaTech merged commit 3d3850d into sprint-2 Nov 5, 2023
@pournasserian pournasserian deleted the 112-refactor-project-architecture-based-on-tech-meeting branch November 5, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants