Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tweak supported/dropped version #4746

Merged
merged 2 commits into from
Dec 26, 2024
Merged

ci: tweak supported/dropped version #4746

merged 2 commits into from
Dec 26, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Dec 26, 2024

Which issue(s) this PR fixes:

Fixes #

What this PR does / why we need it:

Tweak current CI targets.

Added: Ruby 3.4
Dropped: Ruby 3.0/2.7

Ruby 2.7 EOL: 2023-03-31
Ruby 3.0 EOL: 2024-04-23

NOTE: until PR is merged [1], 3.4 points 3.4.0-rc1.

[1] ruby/setup-ruby#677

Docs Changes:

N/A

Release Note:

N/A

Added: Ruby 3.4
Dropped: Ruby 3.0/2.7

Ruby 2.7 EOL: 2023-03-31
Ruby 3.0 EOL: 2024-04-23

NOTE: until PR is merged [1], 3.4 points 3.4.0-rc1.

[1] ruby/setup-ruby#677

Signed-off-by: Kentaro Hayashi <[email protected]>
@daipom
Copy link
Contributor

daipom commented Dec 26, 2024

Thanks!
Don't we remove this in this PR?

rubygems: latest

This reverts commit a5cccf5.

This fix is only required for Ruby 3.0.
As required ruby version is bumped up to 3.2, no need to apply anymore.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Dec 26, 2024

It should be removed, thanks.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit b01e71b into fluent:master Dec 26, 2024
7 of 13 checks passed
@kenhys kenhys deleted the tweak-ci branch December 26, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants