-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add udp and tcp input #368
Conversation
StreamInput based TcpInput is obsoleted since 2+ years ago. So we can remove this class for newer plugin
I will take a closer look and test today. It might be a good idea to check with @frsyuki why the standard socket library wasn't used initially. |
I tested this locally on Ubuntu Precise VM.
|
@kiyoto Thank you for testing.
Hm. I can remove |
I also add "source_host_key" option to add source host to records. |
@frsyuki @kiyoto @tagomoris @sonots Do you have any concern to merge this PR? |
I think that using TcpInput directly is obsolete now. |
No. Old TcpInput is obsoleted since 2 and half years ago so there is no users. |
I see. |
@kiyoto Follow in_tail way. Now in_udp and in_tcp removes a delimiter from message. Please check. |
If there is no problem, I will merge this PR |
General approach for resolving #363
@kiyoto Could you check this PR?