Sleep if readable sockets are empty #1684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
reviewed
Sep 6, 2017
| @@ -493,7 +493,10 @@ def ack_reader | |||
| end | |||
|
|
|||
| readable_sockets, _, _ = IO.select(sockets, nil, nil, select_interval) | |||
| next unless readable_sockets | |||
| unless readable_sockets | |||
There was a problem hiding this comment.
Could you add comment why this sleep is needed?
|
I noticed that this PR cannot fix #1665. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can reduce CPU usage following case:
Sender enables
require_ack_response.If (2) is disconnected, but sender send logs to ELB and wait for ack responses. Soeckets that are waiting for ack response cannot be readable for long time.
This will cause busy loop here.