Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using type in the ruby configuration DSL gives "'type' is deprecated" warning #2028

Closed
adammw opened this issue Jun 21, 2018 · 1 comment
Closed
Assignees
Labels
bug Something isn't working v1

Comments

@adammw
Copy link
Contributor

adammw commented Jun 21, 2018

Using type in the ruby configuration DSL gives "'type' is deprecated" warning, even though there is no alternative. All tests in test/config/test_dsl.rb use the "type" parameter, and @type would be a reserved ruby keyword for instance variables.

Minimal config.rb example:

source {
  type :forward
}

match('**') {
  type :null
}

Running with fluent/fluentd:v1.0.2-debian docker image in dry-run mode, get the log warning:

2018-06-21 21:02:16 +0000 [info]: fluent/log.rb:316:info: parsing config file is succeeded path="/fluentd/etc/fluent.conf.rb"
2018-06-21 21:02:16 +0000 [info]: fluent/log.rb:316:info: starting fluentd-1.0.2 as dry run mode ruby="2.3.3"
2018-06-21 21:02:16 +0000 [warn]: fluent/log.rb:336:warn: 'type' is deprecated parameter name. use '@type' instead.
2018-06-21 21:02:16 +0000 [trace]: fluent/log.rb:275:trace: registered output plugin 'null'
2018-06-21 21:02:16 +0000 [trace]: fluent/log.rb:275:trace: registered buffer plugin 'memory'
2018-06-21 21:02:16 +0000 [warn]: fluent/log.rb:336:warn: 'type' is deprecated parameter name. use '@type' instead.
2018-06-21 21:02:16 +0000 [trace]: fluent/log.rb:275:trace: registered input plugin 'forward'
@repeatedly
Copy link
Member

Patch is here: #2034

@repeatedly repeatedly added bug Something isn't working v1 labels Jun 25, 2018
@repeatedly repeatedly self-assigned this Jun 25, 2018
repeatedly added a commit that referenced this issue Jun 26, 2018
…ameter

dsl: Need '@' prefix for reserved system parameters. fix #2028
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1
Projects
None yet
Development

No branches or pull requests

2 participants