Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use test-unit-rails instead of rspec-rails #254

Merged
merged 46 commits into from
Aug 8, 2018
Merged

Use test-unit-rails instead of rspec-rails #254

merged 46 commits into from
Aug 8, 2018

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Aug 6, 2018

Because:

  • current specs use both "should API" and "expect API"
  • current specs use complex usage of "let", "before", "subject" and "shared examples"
  • I don't want to keep maintaining such a complex specs

Close #174

okkez added 30 commits July 25, 2018 18:28
@okkez
Remove spec files
2ed91f9 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Replace rspec-rails with test-unit-rails
b169950 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Enable test_unit
70c1985 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Simplify
7801282 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test for some classes
5dc6597
@okkez
Add WebMock
be4753a 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add models/plugin_test.rb
9ff7a7e 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add models/user_test.rb
fdcf676 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add helper module FixutrePath
2f88d59 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/lib/filte_reverse_reader_test.rb
ca79266 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/dashboard_test.rb
00d06c3 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add more assertions
51e900d 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/fluentd_ui_update_checking_test.rb
10d2876 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/sesstions_test.rb
d617f9f 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Remove needless configuration
4f950bb 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use chromedriver-helper and update gems
4927e7e 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Return daemon instance from stub_daemon
14857e8 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add integration test
7a6d813 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add system test using JavaScript
b01ad26 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Strip heredoc
a7247df 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/fluentd/setting/histories_test.rb
3567a98 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/fluentd/setting/notes_test.rb
2e3d599 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/integration/fluentd/setting/running_backup_test.rb
949ca1a 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/decorators/plugin_decorator_test.rb
b537b9d 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/controllers/application_controller_test.rb
bc76f8c 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/controllers/polling_controller_test.rb
5d25cf1 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Remove garbage
a6e90b0 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/controllers/misc_controller_test.rb
04b043c 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/controllers/fluentd/agents_controller_test.rb
a6d31ee 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/lib/*_test.rb
90e6df5 
Signed-off-by: Kenji Okimoto <[email protected]>
okkez added 16 commits August 2, 2018 11:13
@okkez
Add test/system/fluentd/setting/*_test.rb
a2f0a29 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/models/fluentd/agent_test.rb
e6e2647 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test/models/fluentd/setting/*_test.rb
5b88256 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use reactive property properly
937fc90 
In previous version, we have modified read-only property directly.

Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use Rails.csrfToken() to avoid CSRF error while system test
995c5cd 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add comment for debugging JavaScript error
789deb6 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Remove needless attribute
33a1df8 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Update test/system/source_and_output_test.rb
5594baf 
Add system test using JavaScript

Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add test for restart strategy
74a0591 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use capybara-screenshot for integration test
4febcfd 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Add missing parameters
d2fe02d 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Organize Gemfile for Ruby2.2
a3ea25b 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
travis: Set chromedriver version
283e4d8 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use github.com/test-unit/test-unit-rails master HEAD
fab9f77 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Use test-unit-rails support-system-test-case branch
0806972 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez
Download chromedriver before disable net connection
c4856db 
Signed-off-by: Kenji Okimoto <[email protected]>
@okkez okkez force-pushed the use-test-unit-rails branch from 5457035 to c4856db Compare August 8, 2018 08:20
@okkez okkez merged commit 037dc06 into fluent:master Aug 8, 2018
@okkez okkez deleted the use-test-unit-rails branch August 8, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@okkez