Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --host option #177

Merged
merged 2 commits into from
Apr 10, 2015
Merged

Add --host option #177

merged 2 commits into from
Apr 10, 2015

Conversation

tanaka51
Copy link
Contributor

@tanaka51 tanaka51 commented Apr 9, 2015

refs #176

I added --host option to start command.

The rackup command runs in the back of start command binds localhost as default on rack/rack#514 . This option enables to change this.

edited: I changed default host to 0.0.0.0 from localhost for backward compatibility.

$ ./bin/fluentd-ui start
Puma 2.11.1 starting...
* Min threads: 0, max threads: 16
* Environment: production
* Listening on tcp://0.0.0.0:9292
$ ./bin/fluentd-ui start --host localhost
Puma 2.11.1 starting...
* Min threads: 0, max threads: 16
* Environment: production
* Listening on tcp://localhost:9292

@@ -10,13 +10,14 @@ class Command < Thor
option :port, type: :numeric, default: 9292
option :pidfile, type: :string, default: File.expand_path('tmp/fluentd-ui.pid', ROOT)
option :daemonize, type: :boolean, default: false
option :host, type: :string, default: 'localhost'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default should be 0.0.0.0 for compatibility.

@tanaka51 tanaka51 force-pushed the support-host-option branch from ce95523 to 86acdca Compare April 9, 2015 10:40
@yoshihara
Copy link

LGTM

yoshihara pushed a commit that referenced this pull request Apr 10, 2015
@yoshihara yoshihara merged commit 78d30c9 into master Apr 10, 2015
@yoshihara yoshihara deleted the support-host-option branch April 10, 2015 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants