Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rspec and capybara again #170

Merged
merged 2 commits into from
Apr 2, 2015
Merged

Upgrade rspec and capybara again #170

merged 2 commits into from
Apr 2, 2015

Conversation

yoshihara
Copy link

I created PR #169 , but I upgraded other gems unexpectedly, so i updated again RSpec and Capybara only.

I'll going to upgrade Rails4.2 (#161), so I upgraded RSpec (~> 3.0) at first.

After RSpec upgrading, warnings is caused so i suppressed them by upgrading capybara.

yoshihara added 2 commits April 2, 2015 14:02
refs #161

The below warning was surpressed by the newest capybara.
 c.f. teamcapybara/capybara#1254

Warning:
--------------------------------------------------------------------------------
Capybara::RSpecMatchers::HaveText implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yoshihara/everyleaf/fluentd-ui/spec/features/fluentd/setting/running_backup_spec.rb:85:in `block (6 levels) in <top (required)>')
--------------------------------------------------------------------------------

And specs are all green :)
@uu59
Copy link
Member

uu59 commented Apr 2, 2015

LGTM

uu59 added a commit that referenced this pull request Apr 2, 2015
@uu59 uu59 merged commit 4ac6605 into master Apr 2, 2015
@uu59 uu59 deleted the upgrade_rspec_and_capybara branch April 2, 2015 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants