Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configtest/update behaviors are mismatched #168

Merged
merged 4 commits into from
Apr 2, 2015
Merged

Fix configtest/update behaviors are mismatched #168

merged 4 commits into from
Apr 2, 2015

Conversation

uu59
Copy link
Member

@uu59 uu59 commented Apr 2, 2015 

<source>
  type forward
  id "foo#{Time.now.to_s}"
</source>

like this config, configtest was passed, but Update & Restart was failed.

This PR fixes that behavior (should be success).

@uu59 uu59 force-pushed the config_parse_also_configtest branch from c595f4a to aaf4f17 Compare April 2, 2015 03:50
@uu59 uu59 changed the title Fix configtest didn't catch syntax error Fix configtest/update behaviors are mismatched Apr 2, 2015
@uu59 uu59 force-pushed the config_parse_also_configtest branch from a1b1f1a to 92d026b Compare April 2, 2015 03:59
@yoshihara
Copy link

LGTM

uu59 added a commit that referenced this pull request Apr 2, 2015
@uu59
Merge pull request #168 from fluent/config_parse_also_configtest
0af3639 
Fix configtest/update behaviors are mismatched
@uu59 uu59 merged commit 0af3639 into master Apr 2, 2015
@uu59 uu59 deleted the config_parse_also_configtest branch April 2, 2015 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uu59 @yoshihara