Enable to add a note with each configuration histories #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move backup_file model under it. prepare for gathering models that concernig about archive
| %td | ||
| = form_for :note, url: daemon_setting_note_path(id: file.note.file_id), method: :patch do |f| | ||
| = f.text_field :content, value: file.note.content, class: "note-content", id: nil | ||
| = submit_tag t('terms.save'), class: 'btn' |
There was a problem hiding this comment.
Apply that class and adjust it with text_field.
| @@ -17,7 +17,7 @@ | |||
| page.should have_css('h1', text: I18n.t('fluentd.settings.show.page_title')) | |||
| page.should have_link(I18n.t('terms.edit')) | |||
| page.should have_css('pre', text: 'GREAT CONFIG HERE') | |||
| expect(all('.row li').count).to eq Settings.histories_count_in_preview #links to hisotries#show | |||
| expect(all('.row tr').count).to eq Settings.histories_count_in_preview + 1 # links to hisotries#show + 1 table header | |||
|
You should remove a related note file on deleting a backup file. |
| end | ||
|
|
||
| def file_id | ||
| @file_id ||= with_file { name.gsub(/.conf\Z/,'') } | ||
| @file_id ||= with_file { name.gsub(/#{self.class::FILE_EXTENSION}\Z/,'') } |
There was a problem hiding this comment.
should Regexp.escape(self.class::FILE_EXTENSION) as @kou commented.
uu59
added a commit
that referenced
this pull request
Jan 7, 2015
Enable to add a note with each configuration histories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables to add a note with each configuration histories.
See the following screen capture.