Add ServerErrorHandler #32
Conversation
| Map<String, Object> data = new HashMap<String, Object>(); | ||
| data.put("k3", "v3"); | ||
| data.put("k4", "v4"); | ||
| logger.log("test01", data); |
There was a problem hiding this comment.
Please add a comment here that says 'writing to the closed socket'
| @@ -132,4 +132,10 @@ public void finalize() { | |||
| public boolean isConnected() { | |||
| return sender != null && sender.isConnected(); | |||
| } | |||
|
|
|||
| public synchronized void setServerErrorHandler(ServerErrorHandler serverErrorHandler) { | |||
| if (sender != null) { | |||
There was a problem hiding this comment.
Passing null handler is user error. Throw IllegalArgumentException here to notify the user that there is something wrong in the code.
There was a problem hiding this comment.
I thought the users can clear the error handler they set before if they pass null. Should we create another API such as resetServerErrorHandler?
There was a problem hiding this comment.
Sounds good. Please add removeXXXHandler (resetXXX sounds settings the handler again)
There was a problem hiding this comment.
I think we need to set errorHandler instance to DefaultErrorHandler to avoid that the user fails to log an exception when (reset|remove)ErrorHandler is called. So reset sounds more appropriate to me.
There was a problem hiding this comment.
Reset to DefaultErrorHandler sounds good.
|
LGTM! |
No description provided.