-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stackdriver: add cloud_logging_base_url #9779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc94712
to
22a2369
Compare
Add the `Cloud_Logging_Base_Url` configuration option to the `out_stackdriver` plugin. Signed-off-by: braydonk <[email protected]>
22a2369
to
34d7c0c
Compare
jefferbrecht
reviewed
Jan 6, 2025
jefferbrecht
approved these changes
Jan 7, 2025
The |
qingling128
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
leonardo-albertovich
pushed a commit
that referenced
this pull request
Feb 4, 2025
Add the `Cloud_Logging_Base_Url` configuration option to the `out_stackdriver` plugin. Signed-off-by: braydonk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Cloud_Logging_Base_Url
configuration option to theout_stackdriver
plugin. This feature is to support alternateuniverse_domain
s in the output plugin. A majority of users will never need to change this.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Please refer to the Valgrind output below. In that output, I used a universe domain that doesn't exist; I don't have an effective way to test an alternate universe domain at the moment. I also tested with
https://logging.googleapis.com
manually set through the config to still test the config building path that constructs the domain from the base URL in the config and it worked the same.Valgrind debug output with https://logging-other.com
Valgrind debug output with https://logging.googleapis.com manually set
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1538
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.