tests: internal: added cpu byte order test cases #9270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
requested review from
edsiper,
fujimotos and
koleini
as code owners
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
had a problem deploying
to
pr
GitHub Actions
Failure
leonardo-albertovich
had a problem deploying
to
pr
GitHub Actions
Failure
|
are these tests dependent on another PR ? (CI is failing) |
|
They are not, I'll test them in an x86 system tomorrow since that's what's failing and I only tested this on my laptop on arm mode. |
Signed-off-by: Leonardo Alminana <[email protected]>
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
|
Interestingly enough, the issue was related to the log event encoder buffer type signedness and I didn't see it because my aarch64 linux system behaves differently to x86 systems which reinforces my opinion that PR #8851 should actually be widened in scope to ensure that this doesn't happen again. |
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
leonardo-albertovich
temporarily deployed
to
pr
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.