-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node_exporter_metrics: Align the collecting metrics of unit statuses #9134
node_exporter_metrics: Align the collecting metrics of unit statuses #9134
Conversation
Signed-off-by: Hiroshi Hatake <[email protected]>
adding @pwhelan for review |
@cosmo0920 what's the main difference with the implementation proposed on #9136 ? |
The main difference is: This PR will set all of 0 value at first. And set 1 only for an active state. |
I had not seen originally that this one set the states, since it does just merge this one. I had my PR from before just had not pushed it. |
thanks both |
@cosmo0920 note: |
In the original node_exporter, it only uses 0 or 1 which means that this status is active or not.
To represent this specification on Fluent Bit, we need to fill as 0 at first. Then, we need filling with 1 for the active statuses.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.