in_http: http realloc fus fix, http_server: same fix #8640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recalculate and reassign all the pointers managed by mk_http_request, ie: * request.uri * request.parsers.headers * request.content_type As well as several others. All headers as well as all mk_ptr_t are recalculated when reallocating the request buffer so they point to the new buffer. Signed-off-by: Phillip Whelan <[email protected]>
…fer grows. Reassign pointers in mk_http_request when the buffer grows. Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
Signed-off-by: Phillip Whelan <[email protected]>
|
The in_http patches are superseded by #8643, the http_server fixes will be done via changes to monkey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These patches provide equivalent fixes for both
in_httpand the newhttp_serverwhen it is ingesting http1/.x protocol requests.When large requests are sent with HTTP/1.0 the buffer gets reallocated when reaching or exceeding the initial buffer size. The request (a
struct mk_http_request) uses severalmk_ptr_tto point to values for certain headers and parts of the request and points directly at the buffer.This patch seeks to recalculate those pointers when this happens so they remain valid and point to valid content.
Without this patch
in_httpwill fail, either crashing when usinghttp2=offor returning a 400 "invalid request" error.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.