Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: build: Make to be able to replace docker cli via environment variable #8612

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

cosmo0920
Copy link
Contributor

Theoretically, podman cli could be used for creating packages. The default command for container cli should be docker.
To use podman instead of docker, define FLB_DOCKER_CLI=podman. Then podman is working with build and run commands.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

celalettin1286
celalettin1286 previously approved these changes Mar 21, 2024
@cosmo0920
Copy link
Contributor Author

Sorry, I'd overlooked for shellcheck failure. I re-requested for reviewing.

@patrick-stephens patrick-stephens merged commit 2b05150 into master Mar 21, 2024
16 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-buildable-with-non-docker-cli branch March 21, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants