Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ARES_OPT_TRIES must be set to update opt.tries #8587

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix: ARES_OPT_TRIES must be set to update opt.tries #8587

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d22ee4
fix: ARES_OPT_TRIES must be set to update opt.tries
bazzargh Mar 15, 2024
a2fc10e
fix: remove retries
bazzargh Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/flb_network.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ static struct flb_dns_lookup_context *flb_net_dns_lookup_context_create(
* the number of retries to 2
*/

optmask = ARES_OPT_FLAGS;
optmask = ARES_OPT_FLAGS | ARES_OPT_TRIES;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the flag and the following line?
After some consideration I remembered that due to a design constraint fluent-bit won't allow c-ares to retry so we'll have to wait until that is worked on before we can enable retries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bazzargh ping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just got back from a holiday watching the eclipse! Updated as requested.

opts.tries = 2;

if (dns_mode == FLB_DNS_USE_TCP) {
Expand Down
Loading