-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fleet: use header with main configuration settings. #8102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwhelan
force-pushed
the
pwhelan-fleet-header
branch
from
November 6, 2023 20:11
1aeb6c0
to
fecc7e2
Compare
pwhelan
force-pushed
the
pwhelan-fleet-multifile
branch
from
November 7, 2023 04:07
c22915e
to
e5e293a
Compare
…guration versions. Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Download fleet files to a sub-directory with the timestamp of the relevant configuration and allow it to be loaded by changing to that directory when fluent-bit is reloaded. * Recurse through fleet files and download each one. * Change to the fleet files directory on reload so they can be referred to from the main fleet configuration file. * Delete old fleet file directories when the configuration is deleted. Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
…ration. Use a header.conf file that is refreshed on each invocation of fluent-bit to track the main configuration for the fleet agent. This file is then included by the downloade fleet configuration files. Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
force-pushed
the
pwhelan-fleet-header
branch
from
December 1, 2023 15:14
fecc7e2
to
e617c7b
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fleets save the information for connecting to the fleet into the temporary fleet configuration file. This pull request uses a header.conf file that is then included by the configuration files. This file gets overwritten on each invocation.
This has the advantage of being able to update the base configuration settings, and also allows adding labels with
add_label
, etc...Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.