-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config_format: yaml: add support for idiomatic Yaml camelCase (fix #7593) #7879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) The current Yaml reader is agnostic from the keys format, it only cares to convert them to lower case so the backend layer can configure the properties properly. The following is an non-idiomatic example: env: flushInterval: 1 service: flush: ${flushInterval} pipeline: inputs: - name: random Interval_Sec: 1 filters: - name: record_modifier match: "*" record: powered_by calyptia uuid_key: abc outputs: - name: stdout match: "*" The following patch make the Yaml parser to be idiomatic by supporting a compatible layer with camelCase style for key names, e.g: env: flushInterval: 1 service: flush: ${flushInterval} pipeline: inputs: - name: random intervalSec: 1 filters: - name: record_modifier match: "*" record: powered_by calyptia uuidKey: abc outputs: - name: stdout match: "*" Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
edsiper
requested review from
leonardo-albertovich,
fujimotos and
koleini
as code owners
August 30, 2023 04:59
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Eduardo Silva <[email protected]>
it seems good to go, the only issue is on the macos test that only fails in CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Yaml reader is agnostic from the keys format, it only cares to convert them to lower
case so the backend layer can configure the properties properly. The following is an non-idiomatic
example:
The following patch make the Yaml parser to be idiomatic by supporting a compatible layer with
camelCase style for key names, e.g:
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.