Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_node_exporter_metrics: Fix registering callback for systemd metrics #7876

Conversation

cosmo0920
Copy link
Contributor

Fixed for registering callback settings for systemd metrics.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

fluent-bit starts with: valgrind bin/fluent-bit -i node_exporter_metrics -p metrics=systemd -o stdout

==85698== 
==85698== HEAP SUMMARY:
==85698==     in use at exit: 0 bytes in 0 blocks
==85698==   total heap usage: 128,161 allocs, 128,161 frees, 6,672,526,968 bytes allocated
==85698== 
==85698== All heap blocks were freed -- no leaks are possible
==85698== 
==85698== For lists of detected and suppressed errors, rerun with: -s
==85698== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 changed the title in_node_exporter_metrics: Fix registering callback for systemd in_node_exporter_metrics: Fix registering callback for systemd metrics Aug 28, 2023
@cosmo0920 cosmo0920 temporarily deployed to pr August 28, 2023 07:02 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr August 28, 2023 07:02 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr August 28, 2023 07:02 — with GitHub Actions Inactive
@cosmo0920 cosmo0920 temporarily deployed to pr August 28, 2023 07:35 — with GitHub Actions Inactive
@edsiper edsiper added this to the Fluent Bit v2.1.9 milestone Aug 29, 2023
@edsiper edsiper merged commit 15fb4dc into master Aug 31, 2023
@edsiper edsiper deleted the cosmo0920-node_exporter-fixing-systemd-callbacks-related-stuffs branch August 31, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants