build: Install OpenSSL with chocolatey only for x64 #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because Chocolatey only supports x64 installation after OpenSSL 3.1.1 package. ref: https://community.chocolatey.org/packages/openssl/3.1.1#files Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
patrick-stephens
approved these changes
Jul 19, 2023
patrick-stephens
added
ci
ok-package-test
|
Confirming a full build works, once it does we can merge. |
celalettin1286
approved these changes
Jul 19, 2023
Wiston999
pushed a commit
to Wiston999/fluent-bit
that referenced
this pull request
Aug 7, 2023
* build: Install OpenSSL with chocolatey only for x64 This is because Chocolatey only supports x64 installation after OpenSSL 3.1.1 package. ref: https://community.chocolatey.org/packages/openssl/3.1.1#files Signed-off-by: Hiroshi Hatake <[email protected]> * build: Use the correct directory to refer the installed place of OpenSSL Signed-off-by: Hiroshi Hatake <[email protected]> --------- Signed-off-by: Hiroshi Hatake <[email protected]>
leonardo-albertovich
pushed a commit
that referenced
this pull request
Oct 5, 2023
* build: Install OpenSSL with chocolatey only for x64 This is because Chocolatey only supports x64 installation after OpenSSL 3.1.1 package. ref: https://community.chocolatey.org/packages/openssl/3.1.1#files Signed-off-by: Hiroshi Hatake <[email protected]> * build: Use the correct directory to refer the installed place of OpenSSL Signed-off-by: Hiroshi Hatake <[email protected]> --------- Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because Chocolatey only supports x64 installation after OpenSSL 3.1.1 package.
ref: https://community.chocolatey.org/packages/openssl/3.1.1#files
The CI result is:
https://github.com/fluent/fluent-bit/actions/runs/5596570106/jobs/10233770791
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.