Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: sts_credentials: make STS response parsing less brittle by checking for the full XML end node #7356

Closed

Conversation

PettitWesley
Copy link
Contributor

…ing for the full XML end node


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

…ing for the full XML end node

Signed-off-by: Wesley Pettit <[email protected]>
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:41 — with GitHub Actions Inactive
@PettitWesley
Copy link
Contributor Author

PettitWesley commented May 11, 2023

@edsiper potentially important bug fix, which I've moved to a PR here since I messed up the branch name and PR title the first time around: #7357

This is a cherry-pick. Tested commit here: #7313 (comment)

@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:41 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:42 — with GitHub Actions Inactive
@PettitWesley
Copy link
Contributor Author

PettitWesley commented May 11, 2023

The branch name here is wrong, this is about response parsing not ARN parsing, oops. The commit message is correct.

@PettitWesley PettitWesley changed the title aws: sts_credentials: make STS response parsing less brittle by check… aws: sts_credentials: make STS response parsing less brittle by checking for the full XML end node May 11, 2023
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:52 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:52 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 02:52 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 03:01 — with GitHub Actions Inactive
@PettitWesley PettitWesley temporarily deployed to pr May 11, 2023 03:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant