Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: add version check in release package tests #6390

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Nov 11, 2022

Signed-off-by: Patrick Stephens [email protected]

Minor improvement to release process to verify the version we're expecting is installed.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

Checking for latest works:

$ VERSION_TO_CHECK_FOR=2.0.5 ./test-release-packages.sh 
...
Installation completed. Happy Logging!

Fluent Bit v2.0.5
Git commit: 
+ check_version /tmp/tmp.WAOUgMtLHG
+ [[ -n 2.0.5 ]]
+ local LOG_FILE=/tmp/tmp.WAOUgMtLHG
+ grep -q 2.0.5 /tmp/tmp.WAOUgMtLHG
+ rm -f /tmp/tmp.WAOUgMtLHG
...
$ echo $?
0

Failure case works:

$ VERSION_TO_CHECK_FOR=2.0.4 ./test-release-packages.sh
...
Installation completed. Happy Logging!

Fluent Bit v2.0.5
Git commit: 
+ check_version /tmp/tmp.RwYk6CfwuJ
+ [[ -n 2.0.4 ]]
+ local LOG_FILE=/tmp/tmp.RwYk6CfwuJ
+ grep -q 2.0.4 /tmp/tmp.RwYk6CfwuJ
+ echo 'WARNING: Not using expected version: 2.0.4'
WARNING: Not using expected version: 2.0.4
+ exit 1
$ echo $?
1

No version also passes:

$ ./test-release-packages.sh 
...
$ echo $?
0

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@patrick-stephens patrick-stephens marked this pull request as ready for review November 11, 2022 11:55
@edsiper edsiper merged commit 1c56c3b into master Nov 16, 2022
@edsiper edsiper deleted the improve_package_release_testing branch November 16, 2022 05:15
sumitd2 pushed a commit to sumitd2/fluent-bit that referenced this pull request Feb 8, 2023
Signed-off-by: Patrick Stephens <[email protected]>

Signed-off-by: Patrick Stephens <[email protected]>
Signed-off-by: root <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants